Fade-out sound players even when idle or buffering #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this helps maintain behaviour parity among contiguous and non-contiguous sounds, which in-turn helps maintaining the correct preset state during STOPPING and PAUSING transitions. resolves #1155
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1157 +/- ##
============================================
+ Coverage 29.33% 29.66% +0.32%
- Complexity 437 443 +6
============================================
Files 167 167
Lines 7090 7090
Branches 893 898 +5
============================================
+ Hits 2080 2103 +23
+ Misses 4684 4656 -28
- Partials 326 331 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps maintain behaviour parity among contiguous and non-contiguous sounds. In the current implementation, non-contiguous sounds stop immediately when the underlying media player is idle. It results in an incorrect preset state during
SoundPlayerManager'sPAUSINGandSTOPPINGtransitions.resolves #1155